I've stayed at almost all the Newport properties in the last 2 years. The location of the Onshore is great and even though the units are dated its our preferred spot (the long wharf is a close second). That said it is all about building and room location. Any room close to the water or with a good view makes the dated decor a worthwhile tradeoff (at least in my opinion).
I agree. This is our favorite, too. I would say to avoid the East building as it is furthest from the water, and one of your views would basically be the parking lot and the back of a strip of stores. It is the closest to the indoor pool, though. The West building is, IMO, the best one with units 145 and 146 the best ones in that building. One of those is a 3 bedroom and the other is a 2, but I forget which is which. That 2 bedroom is on the end with windows overlooking the water on 3 sides with unobstructed views. Also, there are real fireplaces, so on a chilly evening, it is amazing to sit with the fire and the view. I would guess that the lower floors would share the same view, but it is probably the best from the top floor (4th).
The staff there is also incredible and responsive, and you could not ask for a better location in Newport. We always get a mid-week tidy even though we are not VIP at this location. If you are a walker (we are), you can walk to the mansions, Cliff Walk, Tennis Museum and more! There is a Ghost Tour that is fun and informational if you are interested in that. You don't even need a car to enjoy the area, shop, eat, and see sights.
I do recommend heading over to Brenton Point for the views and the kite flying as well. We enjoyed eating at Benjamin's. Brick Alley was also good, but I didn't think it was as good as it was hyped to be for us. We also liked the Red Parrot, though it was a bit pricey. All of those are a short walk from the resort. We are also fans of Flo's Clam Shack, though that is a drive. It is mostly fried, but it is fare we don't get often and we enjoy it while in Newport.
If you have kids with you, there is a small aquarium and indoor bounce houses on the beach (not always open, though). There are tons of local playgrounds and a dinner train, too.
We LOVE going to Newport and visit at least yearly. I will add a few pics of our last stay over Christmas, so you can see the unit condition.